[Serializer] Replace Japan timezone with Asia/Tokyo #61438
Merged
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was doing some local experimentation during which one these tests failed due to this timezone. While I did not dig any further why that was the case exactly/why it was missing in this setup, using explicitly not recommended timezones for these tests seem unnecessary. |
The PHP documentation explicitly mentions to not use this timezone and for these tests, it is irrelevant which concrete timezone is used.
d9d2219 to
01714a0
Compare
|
Thank you @mttsch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP documentation https://www.php.net/manual/en/timezones.others.php explicitly mentions to not use this timezone and for these tests, it is irrelevant which concrete timezone is used.