[TypeInfo] Add space after glue comma #61430
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3851224 to
d447afb
Compare
|
7.4 is fine |
|
I'm not sure what's up with these tests. Every time I fix it, and run it, it keeps on failing. Could it be that it's pulling in the officially tagged TypeInfo? |
With this change, it will print a collection type as `array<key, value>` instead of `array<key,value>`. I believe it is more standard than without the space. It's also what Symfony itself does everywhere.
954d63a to
a58ddf5
Compare
|
Thank you @ruudk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it will print a collection type as
array<key, value>instead ofarray<key,value>.I believe it is more standard than without the space. It's also what Symfony itself does everywhere.
Or should this target 8.0?