Skip to content

Remove calls to no-op functions, deprecated in PHP 8.5 #61405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Remove calls to no-op functions, deprecated in PHP 8.5 #61405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...nt/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ protected function setUp(): void
// Normalize intl. configuration settings.
if (\extension_loaded('intl')) {
$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
$this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
}

// Since we test against "de_AT", we need the full implementation
Expand All @@ -55,7 +54,6 @@ protected function tearDown(): void

if (\extension_loaded('intl')) {
ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
}
}

Expand Down Expand Up @@ -346,6 +344,7 @@ public function testReverseTransformFiveDigitYearsWithTimestamp()

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
{
Expand Down Expand Up @@ -378,6 +377,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
{
Expand Down
5 changes: 2 additions & 3 deletions ...nent/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ class NumberToLocalizedStringTransformerTest extends TestCase
private string $defaultLocale;

private $initialTestCaseUseException;
private $initialTestCaseErrorLevel;

protected function setUp(): void
{
// Normalize intl. configuration settings.
if (\extension_loaded('intl')) {
$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
$this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
}

$this->defaultLocale = \Locale::getDefault();
Expand All @@ -41,7 +39,6 @@ protected function tearDown(): void

if (\extension_loaded('intl')) {
ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
}
}

Expand Down Expand Up @@ -664,6 +661,7 @@ public function testReverseTransformENotation($output, $input)

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
{
Expand Down Expand Up @@ -696,6 +694,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
{
Expand Down
5 changes: 2 additions & 3 deletions ...ent/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,12 @@ class PercentToLocalizedStringTransformerTest extends TestCase
private string $defaultLocale;

private $initialTestCaseUseException;
private $initialTestCaseErrorLevel;

protected function setUp(): void
{
// Normalize intl. configuration settings.
if (\extension_loaded('intl')) {
$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
$this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
}

$this->defaultLocale = \Locale::getDefault();
Expand All @@ -41,7 +39,6 @@ protected function tearDown(): void

if (\extension_loaded('intl')) {
ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
}
}

Expand Down Expand Up @@ -492,6 +489,7 @@ public function testReverseTransformForHtml5FormatWithScale()

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
{
Expand Down Expand Up @@ -524,6 +522,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()

/**
* @requires extension intl
* @requires PHP < 8.5
*/
public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
{
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/HttpClient/Internal/CurlClientState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ public function reset(): void
foreach ($this->pushedResponses as $url => $response) {
$this->logger?->debug(\sprintf('Unused pushed response: "%s"', $url));
curl_multi_remove_handle($this->handle, $response->handle);
curl_close($response->handle);
}

$this->pushedResponses = [];
Expand Down
2 changes: 0 additions & 2 deletions src/Symfony/Component/Validator/Constraints/ImageValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,6 @@ public function validate(mixed $value, Constraint $constraint)

return;
}

imagedestroy($resource);
}
}
}
Loading