[Security][TwigBridge] Add access_decision() and access_decision_for_user() #61379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld (antalaron) This PR was merged into the 7.3 branch. Discussion ---------- [Mailer] [Resend] Add friendly name in the `to` field | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | n/a | License | MIT This PR adds support for friendly email address formatting (e.g. "John Doe <john@example.com>") in the `to` field. Although Resend's API accepts this format natively, the current implementation of the bridge does not pass it through correctly — names are silently discarded and only raw email addresses are used. This fix ensures that display names are preserved and passed to the API as intended. Commits ------- f9c0a3d Add friendly name in the `to` field
This new function returns an AccessDecision object, allowing for further treatment in user land such as collecting the vote reasons.
| if ($attachements = $this->prepareAttachments($email)) { | ||
| $payload['attachments'] = $attachements; | ||
| if ($attachments = $this->prepareAttachments($email)) { | ||
| $payload['attachments'] = $attachments; |
There was a problem hiding this comment.
looks like a rebase is needed :)
Comment on lines
+58
to
+60
| public function accessDecision(mixed $role, mixed $object = null, ?string $field = null, ?AccessDecision $accessDecision = null): AccessDecision | ||
| { | ||
| $accessDecision = $accessDecision ?? new AccessDecision(); |
There was a problem hiding this comment.
not there's a point for templates to pass a previous access decision:
Suggested change
| public function accessDecision(mixed $role, mixed $object = null, ?string $field = null, ?AccessDecision $accessDecision = null): AccessDecision | |
| { | |
| $accessDecision = $accessDecision ?? new AccessDecision(); | |
| public function accessDecision(mixed $role, mixed $object = null, ?string $field = null): AccessDecision | |
| { | |
| $accessDecision = new AccessDecision(); |
Comment on lines
+93
to
+95
| public function accessDecisionForUser(UserInterface $user, mixed $attribute, mixed $subject = null, ?string $field = null, ?AccessDecision $accessDecision = null): AccessDecision | ||
| { | ||
| $accessDecision = $accessDecision ?? new AccessDecision(); |
There was a problem hiding this comment.
Suggested change
| public function accessDecisionForUser(UserInterface $user, mixed $attribute, mixed $subject = null, ?string $field = null, ?AccessDecision $accessDecision = null): AccessDecision | |
| { | |
| $accessDecision = $accessDecision ?? new AccessDecision(); | |
| public function accessDecisionForUser(UserInterface $user, mixed $attribute, mixed $subject = null, ?string $field = null): AccessDecision | |
| { | |
| $accessDecision = new AccessDecision(); |
Comment on lines
+68
to
+70
| public function accessDecision(mixed $attributes, mixed $subject = null, ?AccessDecision $accessDecision = null): AccessDecision | ||
| { | ||
| $accessDecision = $accessDecision ?? new AccessDecision(); |
There was a problem hiding this comment.
Suggested change
| public function accessDecision(mixed $attributes, mixed $subject = null, ?AccessDecision $accessDecision = null): AccessDecision | |
| { | |
| $accessDecision = $accessDecision ?? new AccessDecision(); | |
| public function accessDecision(mixed $attributes, mixed $subject = null): AccessDecision | |
| { | |
| $accessDecision = new AccessDecision(); |
Comment on lines
+87
to
+89
| public function accessDecisionForUser(UserInterface $user, mixed $attributes, mixed $subject = null, ?AccessDecision $accessDecision = null): AccessDecision | ||
| { | ||
| $accessDecision = $accessDecision ?? new AccessDecision(); |
There was a problem hiding this comment.
Suggested change
| public function accessDecisionForUser(UserInterface $user, mixed $attributes, mixed $subject = null, ?AccessDecision $accessDecision = null): AccessDecision | |
| { | |
| $accessDecision = $accessDecision ?? new AccessDecision(); | |
| public function accessDecisionForUser(UserInterface $user, mixed $attributes, mixed $subject = null): AccessDecision | |
| { | |
| $accessDecision = new AccessDecision(); |
this is already covered by the AccessDecision::getMessage method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new methods and the corresponding twig helpers to retrieve the access decision from a Voter rather than simply the result. This way, you can enumerate the AccessDecision::votes and retrieve the votes and their reason.
For instance, in a controller or service:
Same for a user on his behalf, and same in Twig;
{% set access = access_decision('post_edit', post) %} <a href="/post/123/edit" {% if not access.isGranted %} title="You don't have access to this post : {{ access.votes|filter(v => v.result = -1)|map(v => v.reasons|join(',')) }}" disabled {% endif %} > Edit this post </a>Given that the main motivation for this is to explain in an API or in twig the reasons why the access is not granted, I'm tempted to pre-filter the failed votes already, or add an extra getter AccessDecision::failedVotes to help create these small extensions ?
Side note: 2 extra commits given that I started in 7.3, will fix if this picks up interest