no longer use 7.4 workaround for COMPOSER_ROOT_VERSION
#61369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPOSER_ROOT_VERSION
d8bc374 to
cda5a14
Compare
stof
reviewed
Aug 18, 2025
stof
reviewed
Aug 18, 2025
| @@ -33,6 +33,9 @@ | |||
| "conflict": { | |||
| "doctrine/dbal": "<4.3" | |||
| }, | |||
| "replace": { | |||
| "symfony/polyfill-php83": "*" | |||
There was a problem hiding this comment.
no-go IMO. Published components must not replace polyfill packages. That shows bad examples (even though this particular replacement is safe due to the PHP 8.4 requirement, but most polyfill replacements are not safe outside final projects)
4fb9aba to
ec0dbbb
Compare
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires tijsverkoyen/CssToInlineStyles#255 to be merged first, but let's try and see what else we need to fix on our side.