Skip to content

no longer use 7.4 workaround for COMPOSER_ROOT_VERSION #61369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 9, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

This PR requires tijsverkoyen/CssToInlineStyles#255 to be merged first, but let's try and see what else we need to fix on our side.

@carsonbot carsonbot added this to the 8.0 milestone Aug 9, 2025
@OskarStark OskarStark changed the title no longer use 7.4 workaround for COMPOSER_ROOT_VERSION no longer use 7.4 workaround for COMPOSER_ROOT_VERSION Aug 9, 2025
@xabbuh xabbuh force-pushed the symfony8 branch 5 times, most recently from d8bc374 to cda5a14 Compare August 14, 2025 19:45
@@ -33,6 +33,9 @@
"conflict": {
"doctrine/dbal": "<4.3"
},
"replace": {
"symfony/polyfill-php83": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-go IMO. Published components must not replace polyfill packages. That shows bad examples (even though this particular replacement is safe due to the PHP 8.4 requirement, but most polyfill replacements are not safe outside final projects)

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 9940184 into symfony:8.0 Aug 18, 2025
@xabbuh xabbuh deleted the symfony8 branch August 18, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants