[HttpKernel] Refine Vary header check to skip special handling of 'Accept-Language' when it's the only entry and '_vary_by_language' is true in CacheAttributeListener
#61368
+77
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
9eec426 to
04f4315
Compare
|
If we want to avoid changing the priority, we can add a condition to check whether the request has the _vary_by_language attribute set to true, and the response's Vary header contains only Accept-Language. |
let's do this, so that this won't interfere with app's listeners |
8240e2d to
8085b7e
Compare
CacheAttributeListener to ensure Vary header is not skippedCacheAttributeListener
8085b7e to
4a186a5
Compare
CacheAttributeListenertrue in CacheAttributeListener
4a186a5 to
85c3d45
Compare
|
status: needs work There is a problem, i will try to resolve that problem tomorrow |
…cept-Language' when it's the only entry and '_vary_by_language' is `true` in `CacheAttributeListener`
85c3d45 to
34293e7
Compare
|
status: needs review The problem was resolved by sending the 'Accept-Language' header at the end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refine Vary header check to skip special handling of 'Accept-Language' when it's the only entry and '_vary_by_language' is true in CacheAttributeListener
Reason
Previously, the
CacheAttributeListenerwas executed after theResponseListener. When theset_locale_from_accept_languageoption is enabled inframework.yaml, theResponseListenersets a Vary header on the response. BecauseCacheAttributeListenerchecks if a Vary header already exists before modifying it, its logic was being bypassed if it ran after theResponseListener.References