Skip to content

Conversation

sadiqk2
Copy link
Contributor

@sadiqk2 sadiqk2 commented Aug 8, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues removing unused code
License MIT

originally commented it out in 2021 from commit sadiqk2@a71fb4b
We can always revisit later if needed. From 2021 its there and not in use

We can always revisit later if needed.From 2021 its there and not in use
@carsonbot carsonbot added this to the 7.4 milestone Aug 8, 2025
@carsonbot carsonbot changed the title [Actions] remove dead code from integration-test [Actions] remove unused code from integration-test Aug 8, 2025
@sadiqk2 sadiqk2 changed the title [Actions] remove unused code from integration-test [CI] remove unused code from integration-test Aug 8, 2025
@sadiqk2 sadiqk2 changed the title [CI] remove unused code from integration-test [CI] remove dead code from integration-test Aug 8, 2025
@carsonbot carsonbot changed the title [CI] remove dead code from integration-test [CI] remove unused code from integration-test Aug 8, 2025
@sadiqk2 sadiqk2 changed the title [CI] remove unused code from integration-test [CI] clean up unused code from integration-test Aug 8, 2025
@sadiqk2 sadiqk2 changed the title [CI] clean up unused code from integration-test [CI] clean up unused code from integration test Aug 8, 2025
@sadiqk2
Copy link
Contributor Author

sadiqk2 commented Aug 11, 2025

@xabbuh Can you approve this ?

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, I leave the final decision to @nicolas-grekas as he initially removed this step and probably knows better if/when it should be re-added

@sadiqk2
Copy link
Contributor Author

sadiqk2 commented Aug 12, 2025

works for me, I leave the final decision to @nicolas-grekas as he initially removed this step and probably knows better if/when it should be re-added

@nicolas-grekas Can you review this

@nicolas-grekas
Copy link
Member

Thank you @sadiqk2.

@nicolas-grekas nicolas-grekas merged commit 4088e6a into symfony:7.4 Aug 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants