Skip to content

Conversation

phpner
Copy link
Contributor

@phpner phpner commented Aug 7, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #60474
License MIT

Description of changes
I have reviewed the translation for the key id="121" and confirmed that it is accurate.
The <target> text remains unchanged, and the attribute state="needs-review-translation" has been removed to mark this translation as fully verified.

These changes address the discussion in issue #60474.

Snip - Administrator symfony-fix local (2)

@carsonbot carsonbot added this to the 6.4 milestone Aug 7, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title (60474) Remove translation state attribute for Twig template validato… [Validator] (60474) Remove translation state attribute for Twig template validato… Aug 7, 2025
@phpner phpner changed the title [Validator] (60474) Remove translation state attribute for Twig template validato… (60474) Remove translation state attribute for Twig template validato… Aug 7, 2025
@GromNaN GromNaN changed the title (60474) Remove translation state attribute for Twig template validato… [Validator] Validate translations for Ukrainian (uk) Aug 7, 2025
@GromNaN
Copy link
Member

GromNaN commented Aug 7, 2025

Thank you @phpner.

@GromNaN GromNaN merged commit 83844d8 into symfony:6.4 Aug 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants