Skip to content

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Using non-public API for cross-components test case dependencies complicates maintenance.

@fabpot fabpot added this to the 7.4 milestone Aug 4, 2025
@nicolas-grekas nicolas-grekas merged commit 9c835fc into symfony:7.4 Aug 4, 2025
12 checks passed
nicolas-grekas added a commit that referenced this pull request Aug 4, 2025
…ttpKernel (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[FrameworkBundle] Decouple ControllerResolverTest from HttpKernel

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Using non-public API for cross-components test case dependencies complicates maintenance.

Commits
-------

4e9c9c1 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel
@nicolas-grekas nicolas-grekas deleted the fwb-test-ctrl branch August 4, 2025 16:59
nicolas-grekas added a commit that referenced this pull request Aug 5, 2025
* 7.3:
  [Scheduler] Fix `scheduler.task` tag arguments optionality
  use false instead of null to hide the currency symbol
  [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand`
  Fix wrong boolean values
  minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas)
  [Messenger] Fix NoAutoAckStamp handling in Worker::flush()
nicolas-grekas added a commit that referenced this pull request Aug 5, 2025
* 7.4:
  Use phpunit attribute
  Remove some implicit bool type juggling
  [Scheduler] Fix `scheduler.task` tag arguments optionality
  use false instead of null to hide the currency symbol
  [FrameworkBundle] Fix block type from `OK` to `ERROR` when local vault is disabled in `SecretsRemoveCommand`
  run tests with PHPUnit 12.1 on PHP >= 8.3
  Fix wrong boolean values
  minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas)
  [Messenger] Fix NoAutoAckStamp handling in Worker::flush()
  [DependencyInjection] Dump XML using plain PHP, no DOM needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants