Skip to content

Conversation

schlndh
Copy link
Contributor

@schlndh schlndh commented Aug 4, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

This change prevents splitting of grapheme clusters due to wrapping in Table. The emoji consists of multiple code points, so CodePointString chunked it into multiple pieces and wordrap then split them into separate lines. E.g.:

--- Expected
+++ Actual
@@ @@
-'👩‍🌾'
+'👩
+‍
+🌾'

@schlndh schlndh requested a review from chalasr as a code owner August 4, 2025 07:59
@carsonbot carsonbot added this to the 6.4 milestone Aug 4, 2025
@carsonbot carsonbot changed the title [Console][Table] Don't split grapheme clusters [Console] [Table] Don't split grapheme clusters Aug 4, 2025
@schlndh schlndh force-pushed the fix-dontSplitGraphemeCluster branch from 965e5cf to c258c19 Compare August 4, 2025 08:03
@nicolas-grekas
Copy link
Member

Thank you @schlndh.

@nicolas-grekas nicolas-grekas merged commit cfe2fcc into symfony:6.4 Aug 4, 2025
10 of 11 checks passed
@schlndh schlndh deleted the fix-dontSplitGraphemeCluster branch August 4, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants