[WebProfilerBundle] Show EventSource requests in debug toolbar
#61311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some screenshots below In progress
Finished successfully
Exception thrown while streaming
|
EventStreams in debug toolbaref33ff6 to
3d3cd2d
Compare
EventSource requests in debug toolbar
3d3cd2d to
339be35
Compare
339be35 to
a4ed7af
Compare
|
👍 Good idea |
| $response->setCallback(static function () use ($callback, $response) { | ||
| $response->sendEvent(new ServerEvent( | ||
| [ | ||
| $response->headers->get('X-Debug-Token') ?? '', |
There was a problem hiding this comment.
this data is static, so why repeat it for every message?
There was a problem hiding this comment.
Hmm what do you mean? It's only included once per stream/request: $callback() outputs all the messages user yielded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show requests originated from js
EventSource(Server-Sent Events) in the web debug toolbar.By using custom event type we should be able to avoid interfering with any app logic.