[HttpFoundation] Add support for structured MIME suffix #61267
Merged
+102
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7beaed to
89470ad
Compare
fabpot
requested changes
Aug 17, 2025
89470ad to
309a6b7
Compare
fabpot
approved these changes
Aug 18, 2025
Expanded the MIME type list in `Request::getMimeTypes()` to include mappings for YAML, WBXML, PDF, and CSV formats.
309a6b7 to
f2ba0b3
Compare
fabpot
approved these changes
Aug 20, 2025
|
Thank you @Spomky. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 20, 2025
…MatTheCat) This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [HttpFoundation] Don’t check suffix on empty MIME type | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Fix tests from #61267 (remaining failures unrelated). Commits ------- 3816617 [HttpFoundation] Don’t check suffix on empty MIME type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended MIME type handling in
Request::getFormat()to support structured suffixes likeapplication/soap+xml. Introduced a private method to define fallback formats based on RFC specifications. Updated the test suite accordingly.It adds supports for common mime types:
soap: application/soap+xml (instead ofxml)problem: application/problem+jsonhal: application/hal+json, application/hal+xmljsonapi: application/vnd.api+jsonyaml: text/yaml, application/x-yamlwbxml: application/vnd.wap.wbxmlpdf: application/pdfcsv: text/csv