-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[FrameworkBundle] Fix lint:container --resolve-env-vars
#61261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+50
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
commented
Jul 29, 2025
$this->assertStringContainsString($expectedOutput, $tester->getDisplay()); | ||
} | ||
|
||
public static function containerLintProvider(): array | ||
{ | ||
return [ | ||
'default container' => ['config.yml', 'The container was linted successfully'], | ||
'missing dump file' => ['no_dump.yml', 'The container was linted successfully'], | ||
['escaped_percent.yml', false, 0, 'The container was linted successfully'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot lint escaped_percent.yml
with --resolve-env-vars
yet.
fabbot failure should be fixed now |
nicolas-grekas
approved these changes
Jul 29, 2025
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php
Outdated
Show resolved
Hide resolved
Thank you @MatTheCat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.2 EOL is around the corner ⏲️
--resolve-env-vars
still won’t work if you have parameters with two escaped percent signs.