Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Another Edge-Case

After I just found #61023 I also tried having properties and getter methods called isFoo and canFoo (no getFoo at this time) in the ObjectWithBooleanPropertyAndIsserWithSameName class:

class ObjectWithBooleanPropertyAndIsserWithSameName
{
    private $foo = 'foo';

    private $isFoo = true;

    private $canFoo = false;

    public function isFoo()
    {
        return $this->isFoo;
    }

    public function canFoo()
    {
        return $this->canFoo;
    }
}

This results in

[
  'isFoo' => true,
  'foo' => true, // it's using the isFoo isser method!
]

Notice, that for the canFoo property it's using the isFoo method to get the value and prints foo as result name.

Reading through the linked PR I wonder if my PR also classifies as "new feature" instead of "bugfix"?
cc @nicolas-grekas

Extended Edge-Case

class ObjectWithBooleanPropertyAndIsserWithSameName
{
    public $foo = 'foo';

    private $getFoo = 'getFoo';

    private $hasFoo = 'hasFoo';

    private $canFoo = 'canFoo';

    private $isFoo = 'isFoo';

    public function getFoo()
    {
        return $this->getFoo;
    }

    public function hasFoo()
    {
        return $this->hasFoo;
    }

    public function canFoo()
    {
        return $this->canFoo;
    }

    public function isFoo()
    {
        return $this->isFoo;
    }
}

Results in

[
  'foo' => 'getFoo',
  'isFoo' => 'isFoo'
]

So we may also want to add the $reflClass->hasProperty($name) check I added for issers for get, has and can?

That would result in:

[
    'getFoo' => 'getFoo',
    'hasFoo' => 'hasFoo',
    'canFoo' => 'canFoo',
    'isFoo' => 'isFoo',
    'foo' => 'getFoo'
]

What do you think, how should we proceed here? Should we do the hasProperty check I added for issers for all getter-like methods? Then we would do the check for:

• getters
• hassers
• canners
• issers

IMO it would definitely make sense for has, can and is. For get it's debatable.

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot