Skip to content

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 26, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #60885 (comment)
License MIT

@xabbuh
Copy link
Member Author

xabbuh commented Jun 26, 2025

@stof Based on your suggestion in #60885. I am just not sure if it's worth it though as we cannot easily change the type in AbstractTransportFactory without breaking backwards compatibility for child classes.

@nicolas-grekas
Copy link
Member

Can you also update AbstractTransportFactory? I agree either we decide the BC break won't have any impact (because we consider nobody is going to redeclare the prop in a child class, which might be fine) - or we'd better not do the change.

@xabbuh
Copy link
Member Author

xabbuh commented Jun 26, 2025

I guess I tend to rather not doing the change at all. Not so much because of someone redeclaring the property but about how the property is passed to concrete AbstractTransport implementations created by such a factory.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 26, 2025

Ah, all transports would need the same change indeed.
Let's close then. If someone cares with a real-world use case we might reconsider.

@xabbuh xabbuh deleted the pr-60885 branch June 26, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants