Skip to content

[FrameworkBundle] skip messenger deduplication middleware registration when no "default" lock is configured #60330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2025
Merged

[FrameworkBundle] skip messenger deduplication middleware registration when no "default" lock is configured #60330

merged 1 commit into from
May 24, 2025

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented May 2, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60329
License MIT

@carsonbot carsonbot added this to the 7.3 milestone May 2, 2025
@lyrixx lyrixx mentioned this pull request May 2, 2025
Closed
@welcoMattic welcoMattic changed the title [FrameworkBundle] Fix messenger dedup middlerware registration when all locks are not named 'default' [FrameworkBundle] Fix messenger dedup middleware registration when all locks are not named 'default' May 2, 2025
nicolas-grekas
nicolas-grekas reviewed May 9, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the title of the PR 😬
The code skips registering messenger when no "default" lock is configured, isn't it?

@lyrixx
Copy link
Member Author

lyrixx commented May 14, 2025

I don't understand the title of the PR 😬 The code skips registering messenger when no "default" lock is configured, isn't it?

yes

@lyrixx lyrixx changed the title [FrameworkBundle] Fix messenger dedup middleware registration when all locks are not named 'default' [FrameworkBundle] skip messenger deduplication middlerware registration when no "default" lock is configured May 14, 2025
@welcoMattic welcoMattic changed the title [FrameworkBundle] skip messenger deduplication middlerware registration when no "default" lock is configured [FrameworkBundle] skip messenger deduplication middleware registration when no "default" lock is configured May 22, 2025
@xabbuh xabbuh added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label May 22, 2025
@norkunas norkunas mentioned this pull request May 22, 2025
Closed
@fabpot
Copy link
Member

fabpot commented May 24, 2025

Thank you @lyrixx.

@fabpot fabpot merged commit 5bddd3f into symfony:7.3 May 24, 2025
11 checks passed
@lyrixx lyrixx deleted the messenger-di branch May 25, 2025 15:54
@fabpot fabpot mentioned this pull request May 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@HypeMC HypeMC HypeMC left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

The service "messenger.middleware.deduplicate_middleware" has a dependency on a non-existent service "lock.factory"
6 participants
@lyrixx @fabpot @nicolas-grekas @HypeMC @xabbuh @carsonbot