[Notifier][Discord] Add DiscordBotTransport
#60218
Merged
+277
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscordBotTransportDiscordBotTransport
9016866 to
b213dbf
Compare
stof
reviewed
Apr 15, 2025
src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Discord/DiscordOptions.php
Outdated
Show resolved
Hide resolved
b213dbf to
c7f59ba
Compare
f1999a2 to
d502376
Compare
DiscordBotTransportDiscordBotTransport
d502376 to
4815173
Compare
|
@OskarStark maybe you could approve here? :) |
4815173 to
f4a9afb
Compare
f4a9afb to
ee429bf
Compare
OskarStark
reviewed
Aug 19, 2025
| $options = $message->getOptions()?->toArray() ?? []; | ||
| $options['content'] = $message->getSubject(); | ||
|
|
||
| if (mb_strlen($options['content'], 'UTF-8') > self::SUBJECT_LIMIT) { |
There was a problem hiding this comment.
Let's remove this username check, if the api responds with an actionable error message. Is this the case?
There was a problem hiding this comment.
Then it should be removed from both transports. Can it be done in a follow-up pr?
OskarStark
approved these changes
Aug 19, 2025
fabpot
approved these changes
Aug 19, 2025
|
Thank you @norkunas. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 20, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [Notifier][Discord] Remove length checks | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #60218 (comment) #60269 (comment) | License | MIT Commits ------- 2780296 [Notifier][Discord] Remove length checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Discord transport is limited because it allows to use only server webhook which sends to a single channel.
I propose to add
DiscordBotTransportwith adiscord+botscheme, so we can send notifications to multiple channels/as direct messages.Our use case that we have a channel where all notifications must be sent and then more important ones also to people as direct messages.