Skip to content

Conversation

wickedOne
Copy link
Contributor

@wickedOne wickedOne commented Mar 14, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #59954
License MIT

this would allow a composer.json file at /alternative/location/composer.json be configured with

  "extra": {
    "runtime": {
      "project_dir": "/../../"
    }
  }

while using

COMPOSER=/alternative/location/composer.json composer update

generate a autoload_runtime.php with the following project_dir

$runtime = new $runtime(($_SERVER['APP_RUNTIME_OPTIONS'] ?? $_ENV['APP_RUNTIME_OPTIONS'] ?? []) + [
  'project_dir' => dirname(__DIR__, 1),
]);

i did not meddle with the autoload template discovery as that's currently already configurable and would introduce a bc break. also it makes sense in a way that every config value is relative to the composer.json file itself

@carsonbot carsonbot added this to the 7.3 milestone Mar 14, 2025
@wickedOne wickedOne changed the base branch from 7.3 to 6.4 March 14, 2025 10:37
- add project_dir to configurable options in composer extra.runtime
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested?
Note that this should target 7.3 as it's an improvement, not a butfix

@@ -74,7 +74,7 @@ public function updateAutoloadFile(): void
}
}

$projectDir = $fs->makePathRelative($projectDir, $vendorDir);
$projectDir = $fs->makePathRelative(realpath($projectDir.($extra['project_dir'] ?? '')), $vendorDir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this miss a /?

Suggested change
$projectDir = $fs->makePathRelative(realpath($projectDir.($extra['project_dir'] ?? '')), $vendorDir);
$projectDir = $fs->makePathRelative(realpath($projectDir.'/'.($extra['project_dir'] ?? '')), $vendorDir);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that makes sense

@wickedOne
Copy link
Contributor Author

wickedOne commented Apr 16, 2025

Can this be tested?

i'm not entirely sure as the plugin uses a lot of built in functions with regards to directory / file locations and a static method to retrieve a composer config.... would you guys even be open to have a dev depdency like vfsStream?

Note that this should target 7.3 as it's an improvement, not a bugfix

check

@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@symfony symfony deleted a comment from carsonbot Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Runtime] project_dir option in composer.json always overwritten in autoload_runtime.php
4 participants