[Mailer] Add attachments support for Sweego Mailer Bridge #59612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Jan 24, 2025
c871524 to
b5b76fc
Compare
chalasr
approved these changes
Jan 26, 2025
fabpot
approved these changes
Jan 27, 2025
|
Thank you @welcoMattic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweego has added support for attachments on their API. This PR include it in the Bridge.
I tested it in a real application with .txt, .pdf and .png files. Mails are delivered with attachments.
As no other Bridge has tests for attachments AFAIK, I didn't write them. It could be part of a dedicated PR.