Skip to content

[Contracts] add missing properties #58520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Contracts] add missing properties #58520

merged 1 commit into from
Oct 10, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 10, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Since #54496 the property is no longer part of the ServiceSubscriberTrait triggering a PHP deprecation like:

Creation of dynamic property Symfony\Contracts\Tests\Service\LegacyTestService::$container is deprecated

@carsonbot carsonbot added this to the 7.1 milestone Oct 10, 2024
@carsonbot carsonbot changed the title [Contracts] add missing properties [Contracts] add missing properties Oct 10, 2024
@xabbuh xabbuh merged commit 846c141 into symfony:7.1 Oct 10, 2024
8 of 10 checks passed
@xabbuh xabbuh deleted the pr-54496 branch October 10, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Contracts Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @stof @carsonbot