Skip to content

[Serializer] Collect denormalization errors for variadic params #58306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

[Serializer] Collect denormalization errors for variadic params #58306

merged 1 commit into from
Oct 3, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Sep 18, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58281
License MIT

Wrap variadic parameters denormalization in a try/catch to collect denormalization errors.

@mtarld mtarld requested a review from dunglas as a code owner September 18, 2024 15:37
@carsonbot carsonbot added this to the 6.4 milestone Sep 18, 2024
@mtarld mtarld mentioned this pull request Sep 18, 2024
Closed
@nicolas-grekas
Copy link
Member

Thank you @mtarld.

@nicolas-grekas nicolas-grekas merged commit 2de4387 into symfony:6.4 Oct 3, 2024
9 of 10 checks passed
@mtarld mtarld deleted the fix/collect-denormalization-exception-for-variadic-parameters branch October 3, 2024 10:19
This was referenced Oct 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mtarld @nicolas-grekas @chalasr @carsonbot