[WebProfilerBundle] Render the toolbar stylesheet #58287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Sep 17, 2024
src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php
Outdated
Show resolved
Hide resolved
rosier
reviewed
Sep 17, 2024
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig
Outdated
Show resolved
Hide resolved
stof
reviewed
Sep 17, 2024
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
smnandre
commented
Sep 17, 2024
src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php
Outdated
Show resolved
Hide resolved
tucksaun
reviewed
Oct 7, 2024
src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Oct 10, 2024
7c9dd5a to
c36fcff
Compare
|
Thank you @smnandre. |
|
This change breaks the style of the toolbar for some users: What about: 1.adding a parameter to use the “old” way? Update: never mind, a solution has been found: |
fabpot
added a commit
that referenced
this pull request
Jan 6, 2025
…xislefebvre) This PR was merged into the 7.2 branch. Discussion ---------- [WebProfilerBundle] fix loading of toolbar stylesheet | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59045 | License | MIT It looks like this PR - #58287 Caused issues with some configurations: - #59045 According to the thumb-up emoji on [this comment](#59045 (comment)) (I don’t have a better measurement of the impact), it affected at least 10 users, with various web servers. Proposals: 1. do not use the `.css` file extension so that servers do not try to serve an actual file 2. if we consider that the disappearance of the style of the profiler’s toolbar is a breaking change, the `.css` file extension could be added back with Symfony 8.0, with a note to help people upgrade (see the workarounds in the issue) Commits ------- 7fef930 fix: loading of WebProfilerBundle’s toolbar stylesheet
If the stylesheet is static why not just serve a static asset instead ? |
|
I guess because service a static asset would require to know its public path, which is harder to grant than a routed URL ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render the (static) toolbar stylesheet separately from the (dynamic) toolbar content.
(avoid the 20ko inlined CSS injection on every page)