[Notifier] [Lox24] Fix request body format to JSON string #57447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 18, 2024
OskarStark
reviewed
Jun 19, 2024
src/Symfony/Component/Notifier/Bridge/Lox24/Tests/Lox24TransportTest.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Jun 19, 2024
src/Symfony/Component/Notifier/Bridge/Lox24/Tests/Lox24TransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jun 19, 2024
src/Symfony/Component/Notifier/Bridge/Lox24/Tests/Lox24TransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Lox24/Tests/Lox24TransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Lox24/Tests/Lox24TransportTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jun 19, 2024
|
Thank you @alebedev80. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After lox24-notifier was release (version 7.1) i've found a bug. Request's header
Content-Typechanged toapplication/x-www-form-urlencodedfromapplication\json.Issue was relate to array type of the body. I've changed it to JSON string and tested. Looks good. Please merge.