Skip to content

[Translation] Fix LocaleSwitcher throws when intl not loaded #54468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2024
Merged

[Translation] Fix LocaleSwitcher throws when intl not loaded #54468

merged 1 commit into from
Apr 3, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Apr 3, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix issue 1505 (from Symfony demo)
License MIT

LocaleSwitcher::setDefault() throw an exception when intl is not installed

"The Symfony\Polyfill\Intl\Icu\Locale::setDefault() is not implemented. Please install the "intl" extension for full localization capabilities."

Fixed by following @stof suggestion

Symfony should ignore this in the LocaleSwitcher, as already done in \Symfony\Component\HttpFoundation\Request::setLocale

@smnandre smnandre requested a review from welcoMattic as a code owner April 3, 2024 07:27
@carsonbot carsonbot added this to the 6.4 milestone Apr 3, 2024
@nicolas-grekas
Copy link
Member

Thank you @smnandre.

@nicolas-grekas nicolas-grekas merged commit ff77282 into symfony:6.4 Apr 3, 2024
This was referenced Apr 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed Translation
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @nicolas-grekas @stof @carsonbot