Skip to content

[Clock] Add a polyfill for DateTimeImmutable::createFromTimestamp() #54442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

[Clock] Add a polyfill for DateTimeImmutable::createFromTimestamp() #54442

merged 1 commit into from
Apr 9, 2024

Conversation

derrabus
Copy link
Member

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues N/A
License MIT

This PR adds the new createFromTimestamp() method introduced in php/php-src#12413 to our DatePoint class. It comes with a polyfill implementation for PHP 8.2/8.3.

@carsonbot carsonbot added this to the 7.1 milestone Mar 30, 2024
@derrabus derrabus force-pushed the feature/create-from-timestamp branch from dbf7abe to 27a7fbb Compare March 30, 2024 16:33
@derrabus
Copy link
Member Author

derrabus commented Mar 30, 2024 •
edited
Loading

I ignored fabbot's proposed exception message formatting because I'd like to stay close to the exception message generated by the upstream implementation.

@derrabus derrabus force-pushed the feature/create-from-timestamp branch from 27a7fbb to 7cf2d71 Compare March 30, 2024 16:56
xabbuh
xabbuh reviewed Apr 1, 2024
View reviewed changes
@derrabus derrabus force-pushed the feature/create-from-timestamp branch from 7cf2d71 to e2e7ffa Compare April 1, 2024 14:01
nicolas-grekas
nicolas-grekas reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed this one :)

@javiereguiluz javiereguiluz added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 2, 2024
@derrabus derrabus force-pushed the feature/create-from-timestamp branch 3 times, most recently from 7ca0fbd to cc1144d Compare April 2, 2024 09:34
@derrabus derrabus requested a review from nicolas-grekas April 2, 2024 11:16
nicolas-grekas
nicolas-grekas reviewed Apr 2, 2024
View reviewed changes
@derrabus derrabus force-pushed the feature/create-from-timestamp branch from cc1144d to 9e48e0d Compare April 9, 2024 08:32
@derrabus
Copy link
Member Author

derrabus commented Apr 9, 2024

Ready

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit a8c43b6 into symfony:7.1 Apr 9, 2024
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 9, 2024
Closed
@derrabus derrabus deleted the feature/create-from-timestamp branch April 9, 2024 09:01
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh xabbuh left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Clock Feature ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @javiereguiluz @xabbuh @carsonbot