Skip to content

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Mar 30, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

Gitlab has also its own emoji shortnames

https://docs.gitlab.com/ee/development/fe_guide/emojis.html

🤐
Github: :zipper_mouth_face:
Gitlab: :zipper_mouth:

(Like lyrixx, my most important PR of the year 😃 )

@alamirault alamirault force-pushed the feature/gitlab-emoji branch from ce25a7c to b11877e Compare March 30, 2024 12:35
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for gitlab should also be added in the emojify Twig filter

@alamirault
Copy link
Contributor Author

Support for gitlab should also be added in the emojify Twig filter

With actual PR #54432, no change is required in filter to support new "locale"

nicolas-grekas added a commit that referenced this pull request Apr 2, 2024
This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Emoji] Update slack data

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Update slack data to latest with make build

Split #54441 in 2 PR as suggested in #54441 (comment)

Commits
-------

1cc41cd [Emoji] Update slack data
@alamirault alamirault force-pushed the feature/gitlab-emoji branch from b11877e to 40a2dec Compare April 2, 2024 17:27
@alamirault alamirault requested a review from stof April 2, 2024 17:28
@stof stof added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 3, 2024
@nicolas-grekas
Copy link
Member

Thank you @alamirault.

@nicolas-grekas nicolas-grekas merged commit cce36cd into symfony:7.1 Apr 3, 2024
@alamirault alamirault deleted the feature/gitlab-emoji branch April 3, 2024 09:29
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emoji Feature ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants