[WebProfilerBundle] Update main menu to display active panels first #54420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 27, 2024
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig
Outdated
Show resolved
Hide resolved
stof
approved these changes
Mar 27, 2024
fabpot
approved these changes
Mar 28, 2024
|
Thank you @javiereguiluz. |
Merged
|
I would like to give my feedback on this. I don't think this change was a good decision. The sidebar items order is now just random so developer never knows at which position the given item will be displayed. So it requires going through all the items from top to bottom to find the desired one (or ctrl+f and typing the panel name but it requires to know all the panel names). Greyed out items are enough IMO What I think would be a good change is to display panels in alphabetical order on the sidebar so I know that Twig will be somewhere at the bottom and Doctrine at the top and my eyes can automatically head in this direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to reorder the main menu items to always display first the active panels, which are the ones that users will click.