Skip to content

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 27, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #53713
License MIT

This PR updates the Symfony\Component\Lock\NoLock stub to implement Symfony\Component\Lock\SharedLockInterface and returns it to being compatible with the Symfony\Component\Lock\LockFactory return types.

@nicolas-grekas
Copy link
Member

Thank you @mbabker.

@nicolas-grekas nicolas-grekas merged commit 9e810de into symfony:7.1 Feb 27, 2024
@mbabker mbabker deleted the 7.1-no-lock-as-shared-lock branch February 27, 2024 16:03
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lock] Narrowed return type of LockFactory makes mocks with NoLock incompatible
5 participants