[Notifer][Smsapi] Set messageId of SentMessage #53634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a new feature to me and must target 7.1 |
|
This is only to fix a existing feature that does not work, and which in the implementation of other SMS operators works. |
OskarStark
reviewed
Jan 25, 2024
src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php
Outdated
Show resolved
Hide resolved
bbf0a51 to
c97ead7
Compare
|
Thank you @tomasz-kusy. |
xabbuh
reviewed
Jan 30, 2024
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug causing the messageId to never be set in the object. SmsApi always returns it.