Skip to content

mark classes implementing the WarmableInterface as final #53151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2023
Merged

mark classes implementing the WarmableInterface as final #53151

merged 1 commit into from
Dec 30, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 20, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Dec 20, 2023
@xabbuh xabbuh force-pushed the final-cache-warmers branch from d5e55b3 to efac9e7 Compare December 20, 2023 08:03
@OskarStark OskarStark changed the title mark classes implementing the WarmableInterface as final mark classes implementing the WarmableInterface as final Dec 29, 2023
@OskarStark OskarStark changed the title mark classes implementing the WarmableInterface as final mark classes implementing the WarmableInterface as final Dec 29, 2023
@xabbuh xabbuh force-pushed the final-cache-warmers branch from efac9e7 to a1cdb47 Compare December 30, 2023 20:46
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6dfa363 into symfony:7.1 Dec 30, 2023
@xabbuh xabbuh deleted the final-cache-warmers branch December 30, 2023 20:54
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot