Skip to content

fix tests #53135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix tests #53135

merged 1 commit into from
Dec 19, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 19, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Dec 19, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Dec 19, 2023

@HypeMC Can you please double-check if this is correct (based on your changes made in #53107)?

HypeMC
HypeMC approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@HypeMC HypeMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside the small comment, looks good.

@xabbuh xabbuh merged commit bb836c4 into symfony:6.4 Dec 19, 2023
@xabbuh xabbuh deleted the pr-50767 branch December 19, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HypeMC HypeMC HypeMC approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @HypeMC @carsonbot