[AssetMapper] Split ImportmapManager into 2 #52120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Oct 18, 2023
| @@ -198,7 +205,6 @@ | |||
| ->set('asset_mapper.importmap.command.require', ImportMapRequireCommand::class) | |||
| ->args([ | |||
| service('asset_mapper.importmap.manager'), | |||
| param('kernel.project_dir'), | |||
There was a problem hiding this comment.
Argument wasn't used - unrelated to this PR
weaverryan
commented
Oct 18, 2023
| /** | ||
| * Provides data needed to write the importmap & preloads. | ||
| */ | ||
| class ImportMapGenerator |
There was a problem hiding this comment.
Class is a copy-and-paste of methods from ImportMapManager with very few changes
aace3f1 to
44cee27
Compare
stof
approved these changes
Oct 18, 2023
44cee27 to
47a5600
Compare
|
The changelog should probably mention this change |
fabpot
approved these changes
Oct 20, 2023
47a5600 to
da648b1
Compare
|
Thank you @weaverryan. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Just a simple "copy-and-paste" of methods from
ImportMapManagerto a newImportMapGenerator. The motivation is performance:ImportMapGeneratoris instantiated on production on every request, so this PR results in 2 unnecessary services (RemotePackageDownloaderandJsDelivrEsmResolver) no longer being instantiated.Thanks!