Skip to content

[SecurityBundle] Fix LogoutRouteLoader PHPDoc #52068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2023
Merged

[SecurityBundle] Fix LogoutRouteLoader PHPDoc #52068

merged 1 commit into from
Oct 16, 2023

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Oct 15, 2023 •
edited
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

Fix little typo in phpdoc, introduced in #50946

cc @MatTheCat for review :)

@alamirault alamirault requested a review from chalasr as a code owner October 15, 2023 16:32
@carsonbot carsonbot added this to the 6.4 milestone Oct 15, 2023
@MatTheCat
Copy link
Contributor

MatTheCat commented Oct 15, 2023 •
edited
Loading

Doesn't $logoutUris' value mean value of $logoutUris? In any case I don't mind 😄

@OskarStark OskarStark changed the title [SecurityBundle] Fix LogoutRouteLoader phpdoc [SecurityBundle] Fix LogoutRouteLoader PHPDoc Oct 16, 2023
@fabpot
Copy link
Member

fabpot commented Oct 16, 2023

Thank you @alamirault.

@fabpot fabpot merged commit eadd41a into symfony:6.4 Oct 16, 2023
@alamirault alamirault deleted the hotfix/50946-fix-phpdoc branch October 16, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
SecurityBundle Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@alamirault @MatTheCat @fabpot @wouterj @OskarStark @carsonbot