Skip to content

[WebProfilerBundle] Fix markup to make link to profiler appear on errored WDT #51985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

[WebProfilerBundle] Fix markup to make link to profiler appear on errored WDT #51985

merged 1 commit into from
Oct 11, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT

Smallest PR you’ll see today.

Before:
image

After:
image

@carsonbot carsonbot added this to the 5.4 milestone Oct 11, 2023
@nicolas-grekas
Copy link
Member

Good catch, thanks @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit 6cfd0bf into symfony:5.4 Oct 11, 2023
@MatTheCat MatTheCat deleted the open-web-profiler-from-errored-wdt branch October 11, 2023 08:45
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
@MatTheCat MatTheCat mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MatTheCat @nicolas-grekas @carsonbot