Skip to content

[FrameworkBundle] Change BrowserKitAssertionsTrait::getClient() to be protected #51793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2023
Merged

[FrameworkBundle] Change BrowserKitAssertionsTrait::getClient() to be protected #51793

merged 1 commit into from
Oct 1, 2023
+2 −1

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Oct 1, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #40817
License MIT

Make BrowserKitAssertionsTrait::getClient() protected (see ticket for use cases).
As getRequest() and getResponse() can easily be retrieved from getClient(), they are still private.

@carsonbot carsonbot added this to the 6.4 milestone Oct 1, 2023
@fabpot fabpot merged commit cd53ccd into symfony:6.4 Oct 1, 2023
@fabpot fabpot mentioned this pull request Oct 1, 2023
Closed
@fabpot fabpot deleted the browser-kit-get-client-protected branch October 1, 2023 07:17
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] Proposal: make BrowserKitAssertionsTrait::getClient/getRequest/getResponse protected
2 participants
@fabpot @carsonbot