Skip to content

[Workflow] List place and transition listeners in profiler #51211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Workflow] List place and transition listeners in profiler #51211

merged 1 commit into from
Oct 20, 2023

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 1, 2023 •
edited
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets fixes #50976
License MIT
Doc PR

image

workflow.webm

@carsonbot carsonbot added this to the 6.4 milestone Aug 1, 2023
stloyd
stloyd reviewed Aug 1, 2023
View reviewed changes
stof
stof requested changes Aug 1, 2023
View reviewed changes
@lyrixx lyrixx force-pushed the workflow-dc-listener branch 3 times, most recently from 4356844 to fbe6046 Compare August 1, 2023 17:10
@lyrixx lyrixx changed the title [Workflow] List place or transition listeners in profiler [Workflow] List place and transition listeners in profiler Aug 1, 2023
@lyrixx lyrixx force-pushed the workflow-dc-listener branch from fbe6046 to dd728d4 Compare August 8, 2023 14:35
@lyrixx lyrixx force-pushed the workflow-dc-listener branch from dd728d4 to 43462d2 Compare August 23, 2023 09:42
@lyrixx
Copy link
Member Author

lyrixx commented Aug 23, 2023

This PR is ready

@lyrixx lyrixx requested a review from nicolas-grekas October 10, 2023 15:23
@lyrixx
Copy link
Member Author

lyrixx commented Oct 10, 2023

This PR is ready for 2 month. I'm gonna merge it by the end of the week if there are not more review

@stof stof added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 10, 2023
stof
stof reviewed Oct 10, 2023
View reviewed changes
@stof
Copy link
Member

stof commented Oct 18, 2023

@lyrixx any chance to fix my latest comments

@lyrixx lyrixx force-pushed the workflow-dc-listener branch from 43462d2 to 122ae70 Compare October 19, 2023 09:16
@lyrixx
Copy link
Member Author

lyrixx commented Oct 19, 2023

Hello @stof. I addressed your comment. Thanks

nicolas-grekas
nicolas-grekas reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.
What about adding some tests?

@lyrixx lyrixx force-pushed the workflow-dc-listener branch from 122ae70 to f8bb17c Compare October 19, 2023 16:19
@lyrixx
Copy link
Member Author

lyrixx commented Oct 19, 2023

@nicolas-grekas I added some tests 👍🏼

fabpot
fabpot requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabbot has a patch for you :)

@lyrixx lyrixx force-pushed the workflow-dc-listener branch 2 times, most recently from 6d8df3f to b69784f Compare October 20, 2023 08:44
fabpot
fabpot requested changes Oct 20, 2023
View reviewed changes
@lyrixx lyrixx force-pushed the workflow-dc-listener branch from b69784f to adcc652 Compare October 20, 2023 08:53
@fabpot
Copy link
Member

fabpot commented Oct 20, 2023

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Oct 20, 2023
Closed
@fabpot fabpot merged commit 91a3a4f into symfony:6.4 Oct 20, 2023
@lyrixx lyrixx deleted the workflow-dc-listener branch October 20, 2023 09:08
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof requested changes

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@stloyd stloyd stloyd left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed Workflow
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

Extend workflow component graph /debugger by event listener actions
6 participants
@lyrixx @stof @fabpot @stloyd @nicolas-grekas @carsonbot