Skip to content

[FrameworkBundle] Simplify marking store configuration #51148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2023
Merged

[FrameworkBundle] Simplify marking store configuration #51148

merged 1 commit into from
Jul 29, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR - 
framework:
    workflows:
        my_workflow:
            marking_store:
                #type: method <= not needed anymore if property is explicitly set
                property: state

@carsonbot carsonbot added this to the 6.4 milestone Jul 28, 2023
@lyrixx
Copy link
Member

lyrixx commented Jul 29, 2023

Thank you Nicolas.

@lyrixx lyrixx mentioned this pull request Jul 29, 2023
Closed
@lyrixx lyrixx merged commit 3666359 into symfony:6.4 Jul 29, 2023
@lyrixx
Copy link
Member

lyrixx commented Jul 31, 2023

@nicolas-grekas this PR needs #50974, right?

@nicolas-grekas nicolas-grekas deleted the fwb-no-wf-type branch July 31, 2023 15:40
@nicolas-grekas
Copy link
Member Author

Not really, but #50974 would be nice yes :)

This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @lyrixx @OskarStark @carsonbot