Skip to content

[HttpKernel] Remove deprecated code paths #50858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

[HttpKernel] Remove deprecated code paths #50858

merged 1 commit into from
Jul 4, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -
  • Remove ArgumentValueResolverInterface, use ValueResolverInterface instead
  • Remove StreamedResponseListener
  • Remove AbstractSurrogate::$phpEscapeMap
  • Remove HttpKernelInterface::MASTER_REQUEST
  • Remove terminate_on_cache_hit option from HttpCache

@carsonbot carsonbot added this to the 7.0 milestone Jul 3, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 3, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 4, 2023
@nicolas-grekas
minor #50859 [Security] Remove ArgumentValueResolverInterface from Us…
29c1efa 
…erValueResolver (nicolas-grekas)

This PR was merged into the 6.4 branch.

Discussion
----------

[Security] Remove ArgumentValueResolverInterface from UserValueResolver

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Needed to unlock #50858 without breaking compat between http-kernel v7 and security-http v6.

Commits
-------

e979e35 [Security] Remove ArgumentValueResolverInterface from UserValueResolver
@nicolas-grekas nicolas-grekas force-pushed the hk-deprec branch 2 times, most recently from 4c39de2 to e0c7372 Compare July 4, 2023 08:58
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 4, 2023
Closed
@nicolas-grekas nicolas-grekas merged commit 0e01e2d into symfony:7.0 Jul 4, 2023
@nicolas-grekas nicolas-grekas deleted the hk-deprec branch July 4, 2023 11:29
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Feature HttpKernel Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot