Skip to content

[ProxyManagerBridge] Drop the bridge #50600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

[ProxyManagerBridge] Drop the bridge #50600

merged 1 commit into from
Jun 9, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

As planned in #48484

@carsonbot carsonbot added this to the 7.0 milestone Jun 8, 2023
derrabus
derrabus approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

stof
stof requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this misses the removal of replace in the root composer.json

@stof
Copy link
Member

stof commented Jun 8, 2023

Btw, Verify Packages currently does not catch this mistake in the CI.

@nicolas-grekas
Copy link
Member Author

this misses the removal of replace in the root composer.json

fixed!

@fabpot
Copy link
Member

fabpot commented Jun 9, 2023

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Jun 9, 2023
Closed
@fabpot fabpot merged commit aca170b into symfony:7.0 Jun 9, 2023
@nicolas-grekas nicolas-grekas deleted the pm-drop branch June 12, 2023 10:21
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Feature ProxyManagerBridge Status: Reviewed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @stof @fabpot @derrabus @carsonbot