[DomCrawler] Avoid passing null to substr/strrpos methods #49983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeckers
approved these changes
Apr 9, 2023
fabpot
approved these changes
Apr 9, 2023
|
Thank you @VincentLanglet. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
resolve('foo', 'http://localhost?bar=1')two php deprecations were triggered.This is because
parse_urlreturns null and then we use the result as a string.I made the code working the same for
resolve('foo', 'http://localhost?bar=1')than forresolve('/foo', 'http://localhost?bar=1')(which was already tested and was not triggering the deprecation).