[Messenger] Do not throw 'no handlers' exception when skipping handlers due to duplicate handling #48120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duplicate handling
nicolas-grekas
approved these changes
Nov 5, 2022
chalasr
approved these changes
Nov 5, 2022
|
Thank you @wouterj. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this change is expected or not, but I found this [while investigating another bug](https://github.com/wouterj/sf-reproducer/tree/messenger-star-routing in the Messenger component. When you handle the same message twice, you'll get an
NoHandlerForMessageExceptionbecause all handlers are skipped.What would be the expected behavior? Maybe we have to throw a different exception when the same envelope is handled twice?