Skip to content

[Messenger] Tell about messenger:consume invalid limit options #48085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

[Messenger] Tell about messenger:consume invalid limit options #48085

merged 1 commit into from
Nov 8, 2022

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48082
License MIT
Doc PR N/A

@MatTheCat MatTheCat requested a review from chalasr as a code owner November 2, 2022 17:18
@carsonbot carsonbot added this to the 4.4 milestone Nov 2, 2022
@derrabus
Copy link
Member

derrabus commented Nov 2, 2022

Tests please. 🤓

@MatTheCat
Copy link
Contributor Author

@derrabus okay, wasn’t sure because in the end an exception would be thrown anyway!

@MatTheCat MatTheCat force-pushed the ticket_48082 branch 2 times, most recently from bc46544 to 5cd2d00 Compare November 2, 2022 17:50
derrabus
derrabus reviewed Nov 2, 2022
View reviewed changes
@derrabus
Copy link
Member

derrabus commented Nov 2, 2022

in the end an exception would be thrown anyway!

Doesn't matter. If we feel like this issue is a bug is worth fixing, we should have tests that make sure it stays fixed.

alamirault
alamirault suggested changes Nov 2, 2022
View reviewed changes
@MatTheCat MatTheCat force-pushed the ticket_48082 branch 3 times, most recently from 51c3f0d to 6475a3a Compare November 5, 2022 10:41
@chalasr
Copy link
Member

chalasr commented Nov 8, 2022

Thank you @MatTheCat.

@chalasr chalasr merged commit 969f19b into symfony:4.4 Nov 8, 2022
@MatTheCat MatTheCat deleted the ticket_48082 branch November 8, 2022 12:48
@fabpot fabpot mentioned this pull request Nov 19, 2022
Merged
@fabpot fabpot mentioned this pull request Nov 28, 2022
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus left review comments

@welcoMattic welcoMattic welcoMattic approved these changes

@chalasr chalasr chalasr approved these changes

+1 more reviewer

@alamirault alamirault alamirault approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@MatTheCat @derrabus @chalasr @welcoMattic @alamirault @carsonbot