[DependencyInjection] Allow array attributes for service tags #47364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @nusje2000 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/DependencyInjection/Loader/Configurator/DefaultsConfigurator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Sep 6, 2022
src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
Outdated
Show resolved
Hide resolved
|
@aschempp Just wanted to say how happy I am that you didn't give up on this idea and finished the PR 👏 🙌 💙 |
welcoMattic
reviewed
Oct 20, 2022
src/Symfony/Component/DependencyInjection/Loader/Configurator/DefaultsConfigurator.php
Outdated
Show resolved
Hide resolved
8be8031 to
edd8d77
Compare
welcoMattic
approved these changes
Oct 24, 2022
|
Thank you @aschempp. |
Merged
|
Hi @aschempp, I can't get this feature to work. $configurator->services()
->set(Foo::class)
->tag('foo', ['bar' => ['baz' => 42]);throws: The tag is accepted by the Am I missing something or should I open an issue ? |
|
@ju1ius looks like you're the first to actually use the feature 😅 |
|
@nicolas-grekas OK, will take a stab at it during the week. |
This was referenced Jan 12, 2023
|
@nicolas-grekas Done in #48958 😉 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 13, 2023
…bute values (ju1ius) This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [DependencyInjection] fixes validation of non-scalar attribute values | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48956 | License | MIT | Doc PR | None As a follow-up to #47364, this PR updates the `CheckDefinitionValidityPass` to allow (possibly nested) arrays of scalars in service tags attribute values. Please see #48956 for context. Commits ------- 88b3e15 [DependencyInjection] fixes validation of non-scalar attribute values
nicolas-grekas
added a commit
that referenced
this pull request
Mar 14, 2024
…so a 'name' property (lyrixx) This PR was merged into the 6.4 branch. Discussion ---------- [DependencyInjection] fix XmlDumper when a tag contains also a 'name' property | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Since #47364, the tag can contain an **array** of attributes. And since #47364, SF uses it to store workflow metadata and also a **name** property. It likely broke the XML generation, and so it brokes `debug:router` command for instance. Sorry, I didn't notice it before! Before the patch, I got that in my container var/cache/dev/App_KernelDevDebugContainer.xml ```xml <tag>workflow<attribute name="name">article</attribute><attribute name="metadata"><attribute name="title">Manage article</attribute></attribute></tag> ``` After, I got ```xml <tag name="workflow"> <attribute name="name">article</attribute> <attribute name="metadata"> <attribute name="title">Manage article</attribute> </attribute> </tag> ``` Commits ------- 4a4b011 [DependencyInjection] fix XmlDumper when a tag contains also a 'name' property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds array attribute support for container service tags as described in #38339. The most notable change is the additions to the XML schema for services, because that's the current limitation for not using array.
This is reopening #38540 as new PR since the other one was ("accidentially") closed 😊
/cc @nicolas-grekas