Skip to content

[Console] Fix comparison with completion api version #47019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

[Console] Fix comparison with completion api version #47019

merged 1 commit into from
Jul 22, 2022

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jul 21, 2022

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46901
License MIT
Doc PR n/a

Comparison introduced in #46901 is wrong.

@GromNaN GromNaN requested a review from chalasr as a code owner July 21, 2022 21:37
@carsonbot carsonbot added this to the 6.2 milestone Jul 21, 2022
@GromNaN GromNaN mentioned this pull request Jul 21, 2022
Merged
@GromNaN GromNaN requested a review from wouterj July 21, 2022 21:40
@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

Thank you @GromNaN.

@fabpot fabpot merged commit 6babf86 into symfony:6.2 Jul 22, 2022
@GromNaN GromNaN deleted the fix-completion-version branch July 22, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GromNaN @fabpot @chalasr @carsonbot