Skip to content

[Serializer] Cannot use Context attribute context in AdvancedNameConverterInterface::denormalize #46847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

[Serializer] Cannot use Context attribute context in AdvancedNameConverterInterface::denormalize #46847

merged 1 commit into from
Jul 4, 2022

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jul 4, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46680
License MIT
Doc PR N/A

I realized we can't use the Context attribute context in an AdvancedNameConverterInterface::denormalize, same as spotted already in 5.4 in #46525.

Also adds the missing CHANGELOG entry for #46680

@ogizanagi ogizanagi requested a review from dunglas as a code owner July 4, 2022 17:08
@carsonbot carsonbot added this to the 6.2 milestone Jul 4, 2022
@fabpot
Copy link
Member

fabpot commented Jul 4, 2022

Thank you @ogizanagi.

@fabpot fabpot merged commit fc4e19b into symfony:6.2 Jul 4, 2022
@ogizanagi ogizanagi deleted the fix-context-denormalize branch July 4, 2022 20:01
@mtarld mtarld mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @fabpot @carsonbot