Skip to content

[FrameworkBundle] Fix BC break in abstract config commands #46434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2022
Merged

[FrameworkBundle] Fix BC break in abstract config commands #46434

merged 1 commit into from
May 22, 2022

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented May 21, 2022 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Fixes #46412

This revert also the unnecessary changes made in ConfigDebugCommand and ConfigDumpReferenceCommand classes

@carsonbot carsonbot added this to the 4.4 milestone May 21, 2022
@yceruto yceruto mentioned this pull request May 21, 2022
Merged
chalasr
chalasr approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabpot
Copy link
Member

fabpot commented May 22, 2022

Thank you @yceruto.

@fabpot fabpot merged commit 826a5d4 into symfony:4.4 May 22, 2022
@yceruto yceruto deleted the fix_bc branch May 22, 2022 20:28
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @fabpot @chalasr @carsonbot