[DoctrineBridge] Treat firstResult === 0 like null #46282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 6, 2022
nicolas-grekas
approved these changes
May 6, 2022
|
Thank you @derrabus. |
Merged
This was referenced May 27, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine ORM has changed its default value for the
firstResultproperty ofQueryandQueryBuilderinstances fromnullto0. Both values should be considered equal: Setting no offset or setting the offset to zero should yield the same results.This new default however confuses our
ORMQueryBuilderLoaderbecause it checks fornullonly. This PR intends to fix that.