Skip to content

[Form] fix populating single widget time view data with different timezones #46216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2022
Merged

[Form] fix populating single widget time view data with different timezones #46216

merged 1 commit into from
Apr 30, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 29, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46137
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Apr 29, 2022
@xabbuh xabbuh requested a review from yceruto as a code owner April 29, 2022 15:50
@xabbuh xabbuh mentioned this pull request Apr 29, 2022
Closed
@xabbuh xabbuh force-pushed the issue-46137 branch 2 times, most recently from 44d65de to 2ef1dad Compare April 29, 2022 16:24
nicolas-grekas
nicolas-grekas reviewed Apr 30, 2022
View reviewed changes
HeahDude
HeahDude approved these changes Apr 30, 2022
View reviewed changes
nicolas-grekas
nicolas-grekas approved these changes Apr 30, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I updated the PR to add the parse format to the constructor)

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit db6fbf9 into symfony:4.4 Apr 30, 2022
@xabbuh xabbuh deleted the issue-46137 branch May 1, 2022 20:46
@RSickenberg
Copy link

Thank you for the PR!

@fabpot fabpot mentioned this pull request May 14, 2022
Merged
This was referenced May 27, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

+1 more reviewer

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @RSickenberg @HeahDude @carsonbot