Skip to content

[PropertyInfo] PhpStanExtractor namespace missmatch issue #45890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

[PropertyInfo] PhpStanExtractor namespace missmatch issue #45890

merged 1 commit into from
Mar 31, 2022

Conversation

Korbeil
Copy link
Contributor

@Korbeil Korbeil commented Mar 30, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44431
License MIT
Doc PR N/A

Thanks to @isypov-andrey report, we found out an issue with namespace matching and the PhpStanExtractor.
In this PR I'm fixing this issue.

  • Test to validate the issue
  • Fix

@Korbeil Korbeil requested a review from dunglas as a code owner March 30, 2022 11:28
@carsonbot carsonbot added this to the 5.4 milestone Mar 30, 2022
@Korbeil Korbeil force-pushed the fix/property-info-namespace-matching branch 3 times, most recently from f4033f1 to 0488946 Compare March 30, 2022 12:41
@Korbeil Korbeil force-pushed the fix/property-info-namespace-matching branch from 0488946 to d46b676 Compare March 30, 2022 13:40
@nicolas-grekas
Copy link
Member

Thank you @Korbeil.

@nicolas-grekas nicolas-grekas merged commit 8352e29 into symfony:5.4 Mar 31, 2022
This was referenced Apr 2, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Korbeil @nicolas-grekas @carsonbot