Skip to content

Conversation

ossinkine
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Since Crowdin requires locales with dash (-) and Symfony operates locales with underscore (_) the provider should correctly format such locales before requests.

@ossinkine
Copy link
Contributor Author

@gndk You are right, en locale is valid and already works with Crowdin. But en_US is also valid and does not work with Crowdin. This PR fixes it.

@carsonbot
Copy link

Hey!

I think @rvanlaak has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

Thank you @ossinkine.

@fabpot fabpot merged commit 727ca9e into symfony:5.4 Mar 26, 2022
This was referenced Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants